Added Login/Logout test #12
Conversation
| # License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| # file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
|
||
| import random |
There was a problem hiding this comment.
we don't use this import here you should remove it
|
Mistakes have been fixed, pep8 passes except for the 80 character rule. |
|
|
||
| from page import Page | ||
|
|
||
|
|
||
| class LoginRegion(Page): | ||
|
|
||
| _sign_up_link_locator = (By.CSS_SELECTOR, ".signup a") | ||
| _sign_up_link_locator = (By.CSS_SELECTOR, '.signup a') | ||
| _login_username_field = (By.CSS_SELECTOR, '.login #log') |
There was a problem hiding this comment.
As 'log' is a unique ID, we should use (By.ID, 'log')
There was a problem hiding this comment.
For all locator variables please could you add a _locator suffix? Thanks :)
There was a problem hiding this comment.
How am I going to keep my lines under 30 characters??? i kid :)
Added appropriate methods to login region. Also, marked failing test as xfail because of captcha
| @@ -0,0 +1,3 @@ | |||
There was a problem hiding this comment.
Can you add the MPL2 license block here pls
There was a problem hiding this comment.
We probably don't need the license in the yaml file.
There was a problem hiding this comment.
If its really a big deal one could just put the license in the root of the repo
Added appropriate methods to login region. Also, marked registration test as
xfail because of captcha